Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificates renewal migration #4971

Merged
merged 15 commits into from
Nov 1, 2024
Merged

Conversation

abachleda-baca
Copy link
Contributor

@abachleda-baca abachleda-baca commented Nov 1, 2024

👀 Purpose

• Migration of Certificate Expiry Check code from https://github.com/ministryofjustice/operations-engineering-certificate-renewal/

♻️ What's Changed

• Job script certificate_expiry_check.py moved to operations-engineering/bin
• Services updated accordingly
• Test run workflow added
• All required secrets added to the repo.

📝 Notes

#4927


✅ Things to Check (Optional)

  • I have run all unit tests, and they pass.
  • I have ensured my code follows the project's coding standards.
  • I have checked that all new dependencies are up to date and necessary.

@abachleda-baca abachleda-baca requested a review from a team as a code owner November 1, 2024 13:16
@abachleda-baca abachleda-baca marked this pull request as draft November 1, 2024 13:16
Copy link
Contributor

github-actions bot commented Nov 1, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.04s
✅ PYTHON flake8 4 0 0.53s
✅ PYTHON isort 4 4 0 0.33s
✅ PYTHON pylint 4 0 2.91s
✅ REPOSITORY gitleaks yes no 1.69s
✅ YAML prettier 2 1 0 0.47s
✅ YAML yamllint 2 0 0.32s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@abachleda-baca abachleda-baca marked this pull request as ready for review November 1, 2024 14:47
@abachleda-baca abachleda-baca merged commit e00276b into main Nov 1, 2024
7 checks passed
@abachleda-baca abachleda-baca deleted the certificates_renewal_migration branch November 1, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants