-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed frame switching by name on Selenium 3 #382
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #382 +/- ##
============================================
- Coverage 90.19% 89.87% -0.32%
- Complexity 168 174 +6
============================================
Files 1 1
Lines 469 484 +15
============================================
+ Hits 423 435 +12
- Misses 46 49 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest splitting the usage of Selenium 3 in CI into a separate PR as this is failing in CI (and maybe not worth the trouble given we have our new driver that aims at supporting it better)
c3382cf
to
73869e4
Compare
I've also created a PR instaclick/php-webdriver#132 to allow WebDriver to properly convert WebElement into JSON (as it should be doing initially). When it's merged + release is made that would allow me to remove that ugly WebElement wrapping code, that surely doesn't belong to this repo at all. |
b0e2369
to
900ba20
Compare
@stof , please review. Ideally please review my other PRs as well: https://github.com/minkphp/MinkSelenium2Driver/pulls/aik099 . |
900ba20
to
1a2dbf9
Compare
Fixes this error from the #383:
Implementation ported from the https://github.com/minkphp/webdriver-classic-driver.
It appears, that on Selenium 3 frame switching is possible only by index or WebElement. This PR implements the later approach. In Selenium 2 frame switching by its name/id was also supported.
Additionally, the build script was updated to run tests on Selenium 3 in addition to Selenium 2. Should I split the build script change into a separate PR?