Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Add HTTPS option specific for manifest load #42

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

naganowl
Copy link

Similar to the other manifest options (host + port), we should be able to specify the protocol for serving the manifest file. This is helpful for allowing the server be proxied via HTTPS but still run the dev server via HTTP.

Similar to the other manifest options (host + port), we should be able to specify the protocol for serving the
manifest file. This is helpful for allowing the server be proxied via HTTPS but still run the dev server via
HTTP.
@juanca
Copy link

juanca commented Jul 22, 2016

Something to consider as well: it seems the assets will most likely need to be served in whichever protocol the rails serves its own assets -- which means the manifest needs to be served on the same protocol. However, assets can be proxied between HTTPS <-> HTTP via, say, nginx.

In the current state of webpack-rails, the assets protocol and manifest protocol needs to be specified because the assets view helper always returns the full url (with the protocol). However, if that can be configured (since a protocol-less url will inherit the container protocol (hopefully?)), then having different specified protocols is not needed. The webpack dev server can run in HTTP: the assets will inherit HTTPS from the container but that request is proxied to HTTP, and the manifest file can be served regularly as HTTP.

Unfortunately, I haven't really tested this idea yet. Might also fork and see if it can play out well (though currently using this fork).

Juan-Carlos Medina and Naomi Jacobs and others added 2 commits September 14, 2016 14:52
But still raise if webpack failed to bundle
Only fail if webpack actually failed to build modules
@juanca
Copy link

juanca commented Oct 27, 2016

Can we get some input on these changes?

Being able to specify a different protocol makes sense to our application. The rails server does not need HTTPS but our clients (browsers) do need HTTPS.

We're also happy to keep our fork but I think it'll be benificial for others.

@mipearson
Copy link
Owner

I'm struggling to understand the requirement here, along with the other pull requests regarding HTTPS - what is your use case that https is a development (rather than production) requirement?

@juanca
Copy link

juanca commented Oct 28, 2016

Our rails application runs in HTTPS for development and production (and it is something that will most likely not change in the near future). This allows our development environment to mimic production.

shirish-pampoorickal and others added 2 commits July 11, 2017 16:16
Merge in latest from mipearson/webpack-rails
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants