-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIR_EVAL_392 : added SegmentType, optimized segment.evaluate checks #393
base: main
Are you sure you want to change the base?
Conversation
Mintas
commented
Nov 11, 2024
- Added SegmentType enum, allows to use SegmentType.BOUNDARY and provide list of breakpoints instead of intervals into methods deviation and detection; fixes Segment: make it possible to provide boundaries, not only intervals #392
- Refactored some validations to slightly optimize evaluate method
- Reduced copy-paste, increasing readability
@bmcfee as our chief segment officer, any thoughts? |
5b7dfe5
to
0906e77
Compare
A few thoughts:
|
Thank you for your quick response! It took me some time to come up with a good solution and I decided to split this PR into two independent parts. (1) I do agree, that intervals represent the right unit of segmentation, though there are some subtasks of segmentation process that also require proper evaluation, like unsupervised segmentation and boundary detection itself. Some metrics of segment.eval (mostly detection and deviation) come really handy in those applications. Although some (definitely not all) libraries providing algorithm implementations for this kind of tasks expose some api to validate results, there is lack of well-defined standard for them. P.S. |