Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of Octokit to 4.0.1 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matt-richardson
Copy link

I just discovered this package - it looks perfect for what I need.

Unfortunately, trying to pull it into a new project, I get

[CS0012] The type 'GitHubClient' is defined in an assembly that is not referenced. You must add a reference to assembly 'Octokit, Version=0.32.0.0, Culture=neutral, PublicKeyToken=null'.

I need some of the fixes & features in newer versions of Octokit, so I cant really go back to the old version.

It'd be great if you could merge and release this, so we can use it with the latest version of Octokit

So it can be used with latest version of Octokit
@matt-richardson
Copy link
Author

PS - the tests failed locally when I ran them with this, but... the test in question also failed without any changes - I think it's a pre-existing issue.

Xunit.Sdk.EqualException
Assert.Equal() Failure
Expected: 40
Actual:   41
   at Octokit.Extensions.Tests.Integration.ResilientGitHubClientTests.MakesCachedWrappedOctokitRequest() in octokit.net.extensions/src/Octokit.Extensions.Tests.Integration/ResilientGitHubClientTests.cs:line 34

@vizipi
Copy link

vizipi bot commented Oct 28, 2022

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

No other active qualified developers found to review these specific changes. You might consider involving more team members with these code segments.


Potential missing files from this Pull request

No files found with a 40% threashold :)
No commonly committed files found with a 40% threashold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant