Skip to content

Commit

Permalink
document various v8 bugs (#4808)
Browse files Browse the repository at this point in the history
closes #4805
  • Loading branch information
alexlamsl authored Mar 20, 2021
1 parent 24619da commit 8ea1ced
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 41 deletions.
13 changes: 13 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1296,3 +1296,16 @@ To allow for better optimizations, the compiler makes various assumptions:
// SyntaxError: Identifier 'e' has already been declared
```
UglifyJS may modify the input which in turn may suppress those errors.
- Some versions of Chrome and Node.js will give incorrect results with the
following:
```javascript
console.log({
...{
set 42(v) {},
42: "PASS",
},
});
// Expected: { '42': 'PASS' }
// Actual: { '42': undefined }
```
UglifyJS may modify the input which in turn may suppress those errors.
2 changes: 1 addition & 1 deletion test/compress/classes.js
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ unused_await: {
(() => console.log(await))();
})();
}
expect_stdout: "PASS"
expect_stdout: true
node_version: ">=12"
}

Expand Down
5 changes: 1 addition & 4 deletions test/compress/loops.js
Original file line number Diff line number Diff line change
Expand Up @@ -836,10 +836,7 @@ for_of: {
console.log(async);
}
expect_exact: 'var async=["PASS",42];async.p="FAIL";for(async of(null,async))console.log(async);'
expect_stdout: [
"PASS",
"42",
]
expect_stdout: true
node_version: ">=0.12"
}

Expand Down
51 changes: 15 additions & 36 deletions test/ufuzz/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,9 @@ var SUPPORT = function(matrix) {
template: "``",
trailing_comma: "function f(a,) {}",
});
if (SUPPORT.exponentiation && sandbox.run_code("console.log(10 ** 100 === Math.pow(10, 100));") !== "true\n") {
SUPPORT.exponentiation = false;
}

var VALUES = [
'"a"',
Expand Down Expand Up @@ -241,40 +244,13 @@ BINARY_OPS = BINARY_OPS.concat(BINARY_OPS);
BINARY_OPS = BINARY_OPS.concat(BINARY_OPS);
BINARY_OPS.push(" in ");

var ASSIGNMENTS = [
"=",
"=",
"=",
"=",
"=",
"=",
"=",
"=",
"=",
"=",

"=",
"=",
"=",
"=",
"=",
"=",
"=",
"=",
"=",
"=",

"+=",
"+=",
"+=",
"+=",
"+=",
"+=",
"+=",
"+=",
"+=",
"+=",

var ASSIGNMENTS = [ "=" ];
ASSIGNMENTS = ASSIGNMENTS.concat(ASSIGNMENTS);
ASSIGNMENTS.push("+=");
ASSIGNMENTS = ASSIGNMENTS.concat(ASSIGNMENTS);
ASSIGNMENTS = ASSIGNMENTS.concat(ASSIGNMENTS);
ASSIGNMENTS = ASSIGNMENTS.concat(ASSIGNMENTS);
ASSIGNMENTS = ASSIGNMENTS.concat([
"-=",
"*=",
"/=",
Expand All @@ -285,8 +261,11 @@ var ASSIGNMENTS = [
"<<=",
">>=",
">>>=",
];
if (SUPPORT.exponentiation) ASSIGNMENTS.push("**=");
]);
if (SUPPORT.exponentiation) {
ASSIGNMENTS = ASSIGNMENTS.concat(ASSIGNMENTS);
ASSIGNMENTS.push("**=");
}

var UNARY_SAFE = [
"+",
Expand Down

0 comments on commit 8ea1ced

Please sign in to comment.