fix corner case in dead_code

fixes #5941
mishoo · Sep 28, 2024 · cc76429 · cc76429
1 parent d460c70
commit cc76429
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/lib/compress.js b/lib/compress.js
@@ -13141,8 +13141,8 @@ Compressor.prototype.compress = function(node) {
                 var scope = def.scope.resolve();
                 var local = scope === compressor.find_parent(AST_Lambda);
                 var level = 0, node;
-                parent = compressor.self();
-                if (!(scope.uses_arguments && is_funarg(def)) || compressor.has_directive("use strict")) do {
+                if ((compressor.has_directive("use strict") || !(scope.uses_arguments && is_funarg(def)))
+                    && (parent = compressor.self()) === self) do {
                     node = parent;
                     parent = compressor.parent(level++);
                     if (parent instanceof AST_Assign) {

diff --git a/test/compress/dead-code.js b/test/compress/dead-code.js
@@ -1776,3 +1776,20 @@ issue_5882_3: {
     }
     expect_stdout: "true"
 }
+
+issue_5941: {
+    options = {
+        assignments: true,
+        conditionals: true,
+        dead_code: true,
+    }
+    input: {
+        var a = 1;
+        a = a &&= (a = console) && console.log(typeof a);
+    }
+    expect: {
+        var a = 1;
+        a = (a = a && console) && console.log(typeof a);
+    }
+    expect_stdout: "object"
+}