collision_query: Fixed incorrect triangles position #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
comparison screenshots: before
after
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For scaling physics props, Source gets all the vertices from collision model, scales their position (as it's relative to object, it's a matter of just
position *= scale) and constructs a brand new collide out of that. However, Jolt (or Volt) appears to move model's origin to the center, and then offset it back to original pose by applying custom center of mass, which results in those rebuilt vertices having incorrect position (scaled from the center of the mesh, rather than it's origin). Applying center of mesh position manually to each vertex fixes the issue.