Skip to content

Add performance benchmarking infrastructure #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Davidson-Souza merged 1 commit into from
Aug 28, 2025
Merged

Add performance benchmarking infrastructure #71

Davidson-Souza merged 1 commit into from
Aug 28, 2025

Conversation

@AbdelStark
Copy link
Contributor

@AbdelStark AbdelStark commented Aug 1, 2025 •
edited
Loading

Summary

This PR introduces performance benchmarking infrastructure for Rustreexo, designed to ensure consistent performance monitoring and regression detection across all critical code paths.

Key Features

Benchmark Coverage

  • Stump Operations: Add/remove operations, verification, memory usage patterns
  • Proof Operations: Creation, verification, memory efficiency
  • Accumulator Comparisons: Performance analysis across MemForest, Stump, and Pollard implementations

CI/CD Integration

  • Automated Benchmarks: Runs on pushes to main branches and performance-related branches
  • Performance Regression Detection: Compares PR performance against main branch with statistical analysis
  • Cross-Platform Testing: Ubuntu and macOS runners with environment optimization

CI Workflow Design

  • Main Benchmark Workflow: Comprehensive testing with HTML report generation
  • Regression Detection: PR-triggered performance comparison with baseline
  • Performance Monitoring: Scheduled daily runs with trend analysis
  • Timeout Management: 30-minute limits with optimized parameter ranges

Code Quality Improvements

  • Fixed all clippy warnings across the codebase
  • Improved format string usage and error handling

Testing

All benchmarks compile and run successfully with the new infrastructure.

@AbdelStark AbdelStark changed the title Add comprehensive performance benchmarking infrastructure Add performance benchmarking infrastructure Aug 1, 2025
Davidson-Souza
Davidson-Souza reviewed Aug 14, 2025
View reviewed changes
Copy link
Collaborator

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong conceptACK. Just a few comments.

Also, could you squash these for merge?

@AbdelStark
Add performance benchmarking infrastructure
76efe0b 
Introduces comprehensive performance benchmarking infrastructure for Rustreexo:

- Add CI/CD integration with automated benchmarks on pushes and PRs
- Implement benchmark coverage for Stump, Proof, and Accumulator operations
- Add cross-platform testing on Ubuntu and macOS with environment optimization
- Include performance regression detection and statistical analysis
- Add timeout management and parameter optimization for CI workflows
- Fix clippy warnings across the codebase for improved code quality
- Update MSRV to 1.63.0 for criterion compatibility
@AbdelStark AbdelStark force-pushed the performance/benchmarks branch from 934ca6f to 76efe0b Compare August 28, 2025 08:34
@Davidson-Souza Davidson-Souza merged commit bfd8ff3 into mit-dci:main Aug 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Davidson-Souza Davidson-Souza Davidson-Souza left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AbdelStark @Davidson-Souza