speedup wf{3,4}_of_wf by factorizing raw matches to definitions #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI looks bugged, it's complaining about python versions AFAICT |
|
Indeed, I'm guessing the docker image or the apt repositories were recently updated, let's see if #158 fixes it |
This greatly reduces term size (tree size 1988106 -> 1121651 for wf3_of_wf). Timings before: (Succeed Qed includes some time which isn't in Time Qed, see also coq/coq#19426) wf3 tactics 2.2s qed 1.09s succeed qed 1.25s wf4 tactics 14.5s qed 7.4s succeed qed 8.5s After: wf3 tactics 1.4s qed 0.6s succeed qed 0.65s wf4 tactics 8s qed 3.6s succeed qed 4s
JasonGross
force-pushed
the
speed-wf-of-wf
branch
from
b0b613f
to
e2473d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly reduces term size (tree size 1988106 -> 1121651 for wf3_of_wf).
Timings before:
(Time Succeed Qed includes some time which isn't in Time Qed, see also coq/coq#19426)
wf3
tactics 2.2s
qed 1.09s
succeed qed 1.25s
wf4
tactics 14.5s
qed 7.4s
succeed qed 8.5s
After:
wf3
tactics 1.4s
qed 0.6s
succeed qed 0.65s
wf4
tactics 8s
qed 3.6s
succeed qed 4s