π‘οΈ Sentinel: [CRITICAL] Fix SQL Injection in file ingestion #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¨ Severity: CRITICAL
π‘ Vulnerability: Client-side SQL Injection via unsanitized filenames.
An attacker could upload a file with a crafted name (e.g.,
test'; DROP TABLE x; --.csv) which, when interpolated into DuckDB SQL queries during ingestion or join operations, could execute arbitrary SQL commands. This could lead to data loss or application crash (DoS).π― Impact:
π§ Fix:
sanitizeFilenamehelper insrc/services/duckdb.tsthat restricts filenames to alphanumeric characters, dots, underscores, and dashes.registerFileto sanitize filenames before registering them with DuckDB.registerFileis always safe for SQL interpolation.β Verification:
registerFilenow returns a sanitized string.pnpm build).ingestCSVandMagicJoinModaluse the returned safe handle.PR created automatically by Jules for task 4592230076301879601 started by @lightmyfireadmin