Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR implements the missing "Open..." file dialog functionality in the native C++ GUI.

Changes:

  1. native/intuitives_daw/src/gui/intuitives_gui.cpp:

    • Added gui_open_file_dialog helper function.
    • macOS: Uses osascript to show a native file picker.
    • Linux: Uses zenity via popen to show a GTK file picker.
    • Windows: Uses GetOpenFileNameA from the Win32 API.
    • Replaced the // TODO in gui_draw_menu_bar with the call to the new function.
  2. native/intuitives_daw/CMakeLists.txt:

    • Added comdlg32 to the target_link_libraries for Windows builds to satisfy the linker for GetOpenFileNameA.

Verification:

  • Confirmed syntax via test file compilation for Linux/Mac logic.
  • Verified Windows code structure against Win32 API docs.
  • Verified CMakeLists.txt parsing via cmake.
  • Cleaned up all build artifacts.

PR created automatically by Jules for task 8764003220878027017 started by @lightmyfireadmin

- Modified `native/intuitives_daw/src/gui/intuitives_gui.cpp` to implement `gui_open_file_dialog` supporting macOS (osascript), Linux (zenity), and Windows (Win32 API).
- Hooked the file dialog to the "Open..." menu item to call `daw_load_project`.
- Updated `native/intuitives_daw/CMakeLists.txt` to link `comdlg32` on Windows for `GetOpenFileName` support.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production
Copy link

Codacy's Analysis Summary

9 new issues (≤ 0 issue)
6 new security issues
14 complexity
2 duplications

Review Pull Request in Codacy →

AI Reviewer available: add the codacy-review label to get contextual insights without leaving GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant