Improve duration parsing heuristic #24
Conversation
- Replaced hardcoded '0' heuristic for `avgDuration` with a robust SQL `CASE` statement. - Implemented regex-based parsing to extract duration values (minutes, hours, days, weeks) from the `durationOfEffect` text column. - Normalized parsed duration values to hours. - Double-escaped regex backslashes to ensure compatibility with Drizzle `sql` template tags. - Updated the return object to use the calculated `avgDuration` instead of a mock value.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codacy's Analysis Summary0 new issue (≤ 0 issue) Review Pull Request in Codacy →
|
Improved the duration parsing logic in
sanandem/src/routes/visualizations/compare/+page.server.tsby replacing a placeholder with a SQL-based heuristic that extracts and normalizes duration strings from the database. This allows for more accurate visualization of medication effect durations.PR created automatically by Jules for task 5402069645698593655 started by @lightmyfireadmin