de-flake a test #1166
Merged
de-flake a test #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ChristopherChudzicki
temporarily deployed
to
github-pages
GitHub Actions
Inactive
ChristopherChudzicki
added
the
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4222
Description (What does it do?)
This PR should resolve
That issue reported a test within
DepartmentListingPage.test.tsxfailing 2/3 times due to finding 'too many elements with heading "role" and name ...'. Locally, I was getting about 2 failures out of 1000 runs, so something seems to have changed since that issue was reported.Anyway, this PR increases school names from 1 word to 3 words, so name collisions should be extremely rare now. (We could also make them unique, but Faker has deprecated that method so I'd rather not add more usages).
Screenshots (if appropriate):
How can this be tested?
CI should pass. Note CI checks on commit 1675010 passed, which use 1000 runs of that test.
Additional Context