fix: handle non-ascii username collisions #2942
Draft
+96
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
#8527
Description (What does it do?)
When OpenEdX returns empty username suggestions for usernames containing non-ASCII characters (like "Nguyễn"), the system was raising an
OpenEdxUserCreateError
instead of falling back to local username generation. This fix implements a fallback mechanism that generates unique usernames locally using random number suffixes when OpenEdX suggestions are unavailable.Changes
_generate_unique_username()
helper function to modularize username generation logic_create_edx_user_request()
to fall back to local username generation when OpenEdX returns empty suggestionsreconcile_edx_username()
to use the same modular username generation functionHow can this be tested?
Nguyễn
. Verify the user gets created both in MITxOnline and edX.