Skip to content
This repository was archived by the owner on Sep 26, 2025. It is now read-only.

Conversation

nikolas
Copy link
Contributor

@nikolas nikolas commented Oct 18, 2017

No description provided.

@giocalitri
Copy link

Thanks for your contribution.
Can you please provide some context in the description?

@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage remained the same at 98.442% when pulling 74eed4b on nikolas:patch-3 into c407bbb on mitodl:master.

@giocalitri
Copy link

I honestly think this requires more work:

We should al least upgrade the test_requirements.txt file as well, qui in general it would be great if setup.py loads the requirements from requirements.txt and test_requirements.txt instead of having duplicate lists.

@nikolas
Copy link
Contributor Author

nikolas commented Oct 25, 2017

Yeah, I agree. I just updated this because it happens to work and, in my day-to-day work, if a newer version of a test library produces passing tests, it might as well be merged. But I understand if you'd rather do a more complete overhaul of the test dependencies instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants