Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MIT Open RC URL #378

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix MIT Open RC URL #378

merged 1 commit into from
Mar 20, 2024

Conversation

ChristopherChudzicki
Copy link
Contributor

What are the relevant tickets?

#377

What's this PR do?

This PR updates doof to use https://mitopen-rc.odl.mit.edu/ for RC. the mit-open-rc URL sort of works but does not support keycloak login.

How should this be manually tested?

Visit https://mitopen-rc.odl.mit.edu/. You should be able to log in via keycloak.

At the time of writing, both
- https://mit-open-rc.odl.mit.edu/ (with dash)
- https://mitopen-rc.odl.mit.edu/ (without dash)

host content. However, only mitopen-rc supports
login via keycloak. Doof should use that URL.
@ChristopherChudzicki ChristopherChudzicki changed the title Use mitopen-rc URL Fix RC URL Mar 18, 2024
@ChristopherChudzicki ChristopherChudzicki changed the title Fix RC URL Fix MIT Open RC URL Mar 19, 2024
@shanbady shanbady self-requested a review March 20, 2024 13:25
@shanbady shanbady self-assigned this Mar 20, 2024
Copy link

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ChristopherChudzicki ChristopherChudzicki merged commit b5264bb into master Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants