Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review hecho, no hubo errores en CSS ni html #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added evidencia-validacion.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions src/App.css
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
/*En general los estilos están bien pero agregaría otros colores solo por dinamismo y en algunas partes como en el about me*/
body {
background-color: black;
color: #d1d1d1;
font-family: "Tajawal", sans-serif;
font-size: 1.2rem;
/*Agregaría centrado de texto*/
text-align: center;
}

h1,
Expand Down
2 changes: 2 additions & 0 deletions src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import Projects from "./components/projects";
import Hobbies from "./components/hobbies";
import Contact from "./components/contact";

//Buen uso de React para dividir propiamente las secciones de la pagina

function App() {
return (
<div className="contaier">
Expand Down
2 changes: 2 additions & 0 deletions src/components/contact.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { faWhatsapp, faGithub } from "@fortawesome/free-brands-svg-icons";
import { faEnvelope } from "@fortawesome/free-solid-svg-icons";

//Tambien acá me areció bien que haya dejado el footer adherido a la parte inferior de la pantalla

class Contact extends React.Component {
render() {
return (
Expand Down
2 changes: 2 additions & 0 deletions src/components/navigation.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import React from "react";
import Navbar from "react-bootstrap/Navbar";
import Nav from "react-bootstrap/Nav";

//Me parece bien que haya dejado este componente fijo en la pantlla

class Navigation extends React.Component {
render() {
return (
Expand Down
2 changes: 2 additions & 0 deletions src/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ body {
sans-serif;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
/*Agregaría centrado de texto*/
text-align: center;
}

code {
Expand Down