Draft
Conversation
it is not a root document anymore
* main: Feature/scan error message (#51) cleanup type add github pipeline to check lint and format # Conflicts: # packages/web2/app/components/profile/errorScans/types.ts # packages/web2/app/ssr.tsx
* main: format define root in vite.config.ts to make it work properly in a monorepo
LukasFritzeDev
requested changes
Oct 7, 2025
packages/web2/app/actions/profile.ts
Outdated
Comment on lines
+51
to
+54
| lastScan: serializeObjectWithIds(lastScan?.toJSON()) as unknown as | ||
| | Scan | ||
| | undefined, | ||
| lastSuccessfulScan: serializeObjectWithIds( |
Member
There was a problem hiding this comment.
Warum braucht es hier nochmal zusätzlich serializeObjectWithIds? Sollte das nicht durch die modelOptions schon automatisch mit drin sein, wenn man toJSON aufruft? Und wenn nicht, wäre es dann vielleicht ein besserer Ansatz die toJSON-Methode in der Klasse zu überlagern?
packages/web2/app/components/profile/modals/EditIntervalModal.tsx
Outdated
Show resolved
Hide resolved
* main: Feature/add average score (#57) # Conflicts: # packages/web2/app/actions/profile.ts
* main: Move alert to interval section Remove icons from Cronjobs interval Adjust layout card shadow, tab radius, wording and icons Adjust layout card shadow, tab radius, wording and icons show edit domain button for `ERR_INVALID_AUTH_CREDENTIALS` and `Navigation timeout of 60000 ms exceeded` errors fix typo cover more error cases
* main: Feature/path generator (#70)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#52