Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Image): don't use a external image #861

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

maaaathis
Copy link
Contributor

I intentionally opted for an absolute image path (https://mittwald.github.io/flow/[...]) instead of a relative local path to demonstrate a real usage scenario. I understand that this image will not render in the review deployment, as it is currently not available on the domain.

However, this is how it will appear once the resource is accessible:
Shottr 2024-10-18 11 11 51

@maaaathis maaaathis self-assigned this Oct 18, 2024
@maaaathis maaaathis linked an issue Oct 18, 2024 that may be closed by this pull request
@maaaathis maaaathis temporarily deployed to github-pages-preview October 18, 2024 09:19 — with GitHub Actions Inactive
@maaaathis maaaathis temporarily deployed to github-pages-preview-storybook October 18, 2024 09:19 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 28.33% 3825 / 13498
🔵 Statements 28.33% 3825 / 13498
🔵 Functions 32.14% 208 / 647
🔵 Branches 55.66% 442 / 794
File CoverageNo changed files found.
Generated in workflow #1597 for commit 817b7f2 by the Vitest Coverage Report Action

@mfal mfal merged commit 1b7769e into main Oct 22, 2024
4 checks passed
@mfal mfal deleted the docs/dont-use-external-images branch October 22, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Image in Docs by one not using cookies
2 participants