Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved CI to catch the problem with incorrect PRL files #738

Closed
wants to merge 3 commits into from
Closed

Improved CI to catch the problem with incorrect PRL files #738

wants to merge 3 commits into from

Conversation

iakov
Copy link
Contributor

@iakov iakov commented Nov 25, 2023 •
edited
Loading

ddalcino
ddalcino approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@ddalcino ddalcino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! It's exactly what I was looking for from #640. Thank you for adding this.

Personally, I would have merged this PR into #640 to keep the test and new code together, but I think all that really matters here is that both PRs are merged at the same time. Well done.

@iakov iakov mentioned this pull request Nov 27, 2023
Merged
@iakov
Copy link
Contributor Author

iakov commented Nov 27, 2023

#739 is a combined PR. Now it is up to you (dear maintainers) to choose :)

@miurahr miurahr closed this in #739 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddalcino ddalcino ddalcino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iakov @ddalcino