Support percent-encoded userinfo as per RFC3986#19
Open
z1ga wants to merge 2 commits intomixxorz:mainfrom
Open
Support percent-encoded userinfo as per RFC3986#19z1ga wants to merge 2 commits intomixxorz:mainfrom
z1ga wants to merge 2 commits intomixxorz:mainfrom
Conversation
Owner
|
Hey @z1ga . This looks great. Would you mind fixing the issues with the tests? |
Author
|
Hey, it took me a while, but it should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds support for percent-encoded userinfo (ie. usernames and passwords with special characters).
Examples:
abc!$%^&:@123as passworduser@example.comas usernameThis is done by percent-decoding username and password parts of the URL as per RFC3986 Section-3.2.1.