Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add missing deps for RPM systems #14183

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: add missing deps for RPM systems #14183

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83ac62f
build: add missing deps for RPM systems
acolombier Dec 14, 2024
56af13c
fixup! build: add missing deps for RPM systems
acolombier Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/rpm_buildenv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ case "$1" in
# builddep mixxx`).
sudo dnf install -y \
appstream \
boost-devel \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is our boost dependency on Fedora? I am not aware that boost is required on Debian based distros.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out it is actually needed on Debian-based system too, as patched in my Devcontainer PR
Boost is a dependency for qm-dsp, rigtorp and libdjinterop

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never had to install it in the past, so I suspect Ubuntu-based OSes ship it by default?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't depend on boost. Only the tests of libdjinterop do. But we don't deal with the tests. We use the prebuild binaries.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with a fresh box on main and can't reproduce so this might not be needed anymore

ccache \
chrpath \
cmake \
Expand Down Expand Up @@ -53,6 +54,7 @@ case "$1" in
lilv-devel \
mesa-libGL-devel \
mesa-libGLU-devel \
mold \
ninja-build \
opus-devel \
opusfile-devel \
Expand Down
Loading