refactor: wait job handling

miyamo2 · Nov 30, 2024 · b8eaba7 · b8eaba7
1 parent b08d79d
commit b8eaba7
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/cmd/create_transient_configmap.go b/cmd/create_transient_configmap.go
@@ -267,11 +267,11 @@ func (o *TransientConfigMapOptions) Run(cmd *cobra.Command) (err error) {
 	go func() {
 		waitJobCompleteArgs := append(waitJobArgs, jobName, "--for=condition=complete")
 		_, wErr := executeKubectlCommand(waitJobContext, waitJobCompleteArgs...)
-		if wErr != nil {
-			select {
-			case <-waitJobContext.Done():
-				return
-			default:
+		select {
+		case <-waitJobContext.Done():
+			return
+		default:
+			if wErr != nil {
 				if err == nil {
 					err = wErr
 				}
@@ -284,14 +284,12 @@ func (o *TransientConfigMapOptions) Run(cmd *cobra.Command) (err error) {
 	go func() {
 		waitJobFailedArgs := append(waitJobArgs, jobName, "--for=condition=failed")
 		_, wErr := executeKubectlCommand(waitJobContext, waitJobFailedArgs...)
-		if wErr != nil {
-			select {
-			case <-waitJobContext.Done():
-				return
-			default:
-				if err == nil {
-					err = wErr
-				}
+		select {
+		case <-waitJobContext.Done():
+			return
+		default:
+			if wErr != nil && err == nil {
+				err = wErr
 			}
 		}
 		complete <- false