Always set index

[newzealandpaul]

The index should always be set, because it will be accessed later in the script and generate a runtime error

What does this PR do?

Sets the index variable to the config's id_start_number, even if id_field was already in the header

Why is this desirable ?

When each row is iterated later on in the script, index will be accessed. If it is not set, a runtime error occurs.

        if config["id_field"] in headers:
            row[config["id_field"]] = index + reader.line_num - 2

[mjordan]

Thanks @newzealandpaul . How would I test this change?

[newzealandpaul]

@mjordan thanks for taking a look. Next week when I am on campus I will try figure out why my use case specifically requires it (when it must be initialised for others). Looking at the code, is there any situation or code path where you wouldn’t want to initialise index? If index isn’t initialised then it should always cause a runtime error. Or am I missing something?

…

On Thu, 3 Oct 2024 at 5:44 PM, Mark Jordan ***@***.***> wrote: Thanks @newzealandpaul <https://github.com/newzealandpaul> . How would I test this change? — Reply to this email directly, view it on GitHub <#828 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACLSGTOTSLTDDYSOXPCNDZZTDSFAVCNFSM6AAAAABPI3DED2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJQGUYDMOJTGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>