Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#222 날짜, 시간 제한 Filter 를 Interceptor 에서 동작하도록 변경 #223

Merged
merged 9 commits into from
Oct 5, 2024

Conversation

Dh3356
Copy link
Contributor

@Dh3356 Dh3356 commented Oct 5, 2024

Description

날짜, 시간 제한 Filter 를 Interceptor 에서 동작하도록 변경

Changes

사용하지 않는 Filter 관련 클래스 제거

  • FilterConfig
  • DateRestrictionFilter
  • BoothOperationTimeFilter
  • ErrorResponseHandler
  • RestFilter

Interceptor 구현

  • DateRestrictionInterceptor
  • BoothOperationTimeRestrictionInterceptor

부스 운영, 축제 운영 restriction 인터셉터 추가

  • WebConfig

RestInterceptor 구현

  • Cors 판단
  • Http Method 와 URL 을 기반으로 Interceptor 수행 여부 판단

RestInterceptor 를 사용하도록

  • AbstractAuthenticationInterceptor

RequestMatcherProvider 인터페이스 구현

  • RequestRestrictionProvider
  • AllowedRequestMatcherProvider

Additional context

Filter 에서 자체적으로 에러 응답을 하고 있기 때문에, CORS 설정에 문제가 있었음
이에 따라 Interceptor 에서 필터링하도록 변경
Closes #222

@Dh3356 Dh3356 added the refactor Refactor Code label Oct 5, 2024
@Dh3356 Dh3356 self-assigned this Oct 5, 2024
Copy link

github-actions bot commented Oct 5, 2024

Test Results

13 files  ±0  13 suites  ±0   2m 1s ⏱️ -32s
62 tests ±0  62 ✅ ±0  0 💤 ±0  0 ❌ ±0 
77 runs  ±0  77 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit db1f372. ± Comparison against base commit f80bcc5.

@Dh3356 Dh3356 merged commit 3cbc700 into develop Oct 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

날짜, 시간 제한 Filter 를 Interceptor 에서 동작하도록 변경
1 participant