docs(cli): center query-unit guidance in scaffold docs#614
docs(cli): center query-unit guidance in scaffold docs#614
Conversation
📝 WalkthroughWalkthroughThis PR establishes a core architectural principle across documentation and policy: 1 SQL file / 1 QuerySpec / 1 repository entrypoint / 1 DTO as the fundamental unit. Updates include a changeset file, modifications to root and template READMEs, policy documentation (AGENTS.md) across multiple repository paths, and new/updated tests to verify documentation consistency. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/ztd-cli/templates/src/repositories/views/AGENTS.md (1)
7-7: Consider linking to parent policy instead of restating it verbatim.Restating the parent query-unit rule here can drift over time; a reference-only phrasing would keep this file focused on directory-local deltas.
Based on learnings: "Keep directory-local deltas in child
AGENTS.mdfiles; avoid restating parent rules in child files."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/ztd-cli/templates/src/repositories/views/AGENTS.md` at line 7, Remove the verbatim restatement "This subtree MUST stay aligned with the parent query-unit rule: 1 SQL file / 1 QuerySpec / 1 repository entrypoint / 1 DTO." from AGENTS.md and replace it with a short reference to the parent policy (e.g., "See parent query-unit rule for repository structure; keep only directory-local deltas here.") so the file links to the canonical rule instead of duplicating it and leaves this doc focused on local exceptions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/ztd-cli/templates/src/repositories/views/AGENTS.md`:
- Line 7: Remove the verbatim restatement "This subtree MUST stay aligned with
the parent query-unit rule: 1 SQL file / 1 QuerySpec / 1 repository entrypoint /
1 DTO." from AGENTS.md and replace it with a short reference to the parent
policy (e.g., "See parent query-unit rule for repository structure; keep only
directory-local deltas here.") so the file links to the canonical rule instead
of duplicating it and leaves this doc focused on local exceptions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: be1c92a4-1c5e-43f7-bbe0-e8ce83f97fa5
📒 Files selected for processing (14)
.changeset/quiet-badgers-smile.mdREADME.mdpackages/ztd-cli/templates/README.mdpackages/ztd-cli/templates/README.webapi.mdpackages/ztd-cli/templates/src/catalog/AGENTS.mdpackages/ztd-cli/templates/src/infrastructure/persistence/AGENTS.mdpackages/ztd-cli/templates/src/infrastructure/persistence/repositories/AGENTS.mdpackages/ztd-cli/templates/src/infrastructure/persistence/repositories/tables/AGENTS.mdpackages/ztd-cli/templates/src/infrastructure/persistence/repositories/views/AGENTS.mdpackages/ztd-cli/templates/src/repositories/AGENTS.mdpackages/ztd-cli/templates/src/repositories/tables/AGENTS.mdpackages/ztd-cli/templates/src/repositories/views/AGENTS.mdpackages/ztd-cli/tests/directoryFinding.docs.test.tspackages/ztd-cli/tests/init.command.test.ts
Closes #601
Summary:
Verification:
Summary by CodeRabbit
Documentation
Tests