Conversation
Commented out breaking code until I fix it. Updated "People also ask" selector so it gets hidden
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with hidden search results by updating selectors and modifying execution timing for style injections. Key changes include switching the script to run at document-start, updating the "People also ask" selector to a more specific parent-based approach, and adding styling adjustments for the AI overview section.
Comments suppressed due to low confidence (1)
Google/GoogleQuestionSuggestionRemover.user.js:11
- Changing the run-at timing to document-start may affect when DOM elements are available for styling. Please verify that this timing change aligns with the intended load behavior to avoid potential issues with element availability.
// @run-at document-start
| HEADER_SELECTOR | ||
| , QUESTION_SELECTOR | ||
| , PEOPLE_ALSO_ASK_SELECTOR | ||
| // , WHAT_PEOPLE_ARE_SAYING_SELECTOR |
There was a problem hiding this comment.
[nitpick] Consider removing the commented-out selectors if they are no longer needed, to reduce clutter and avoid potential confusion during future maintenance.
Attempt at removing YouTube "Playables" section
* Split whenElementAppears to onceElementAppears and wheneverElementAppears * Added disconnectOnDetect option to constructor to support this * Added debugName option to constructor to help identify multiple trackers * Added static array of tracker references to avoid garbage collection * Fix: Proper export (fixes #15) * Fix: Matching element passed to handler rather than mutation element * Fix: Iterating over all mutations to search for selector match
* Documentation updates * Addition of RedditSubredditHider script which uses ObserverTracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commented out breaking code until I fix it.
Updated "People also ask" selector so it gets hidden