Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on MinGW #1169

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Building on MinGW #1169

wants to merge 2 commits into from

Conversation

RoDuth
Copy link

@RoDuth RoDuth commented Feb 20, 2023

fixes #1168

RoDuth added a commit to RoDuth/ghini.desktop that referenced this pull request Feb 20, 2023
Some institutions may prefer. (Not been thoroughly road tested.)
- Mostly accounts for SQL differences and sqlalchemy:
	- exists not allowed in columns clause of select
	- boolean as BIT (is True, casting etc.)
	- tuple comparison
	- group by must include all returned columns
	- don't assume case sensitivity (depends on collation setup)
	- can't use Text without a length if setting unique, conversely
	  Text() in postgresql doesn't accept a length, use String
	- CheckConstraint passes string verbatim and therefore has
	  "limited database independent behaviour".  Switch to
	  enforcing at app level
- some threading issues during tests not seen in other DBMSs
- Test MultiprocCounter against provided database unless using an
  in-memory sqlite db (in which case switch to a temp file)

+ GenericExporterTests - fix occasional fail on datetime type tests
  i.e. when test runs over the second (seems more common using my
  current docker MSSQL setup)
+ some bits and pieces

NOTE:
- end user may still need to install a driver:
  osx - HOMEBREW_ACCEPT_EULA=Y brew install msodbcsql17 mssql-tools
  windows - download and install VC_redist.x64.exe
- pyodbc mingw windows awaiting mkleehammer/pyodbc#1169
@RoDuth
Copy link
Author

RoDuth commented Dec 17, 2024

Had another crack at this due to the need to upgrading to python 3.12.

Only concern I have is over the changes from here #1278. It seems that sqlext.h in MinGW-w64 does not define SQL_OV_ODBC3_80 (or related) at all see. I've included a hack to just avoid compiling this portion but I'm sure there is a much better approach (I have little C/C++).

@RoDuth
Copy link
Author

RoDuth commented Dec 19, 2024

Fixed above and added test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

building on MSYS2 MINGW64
1 participant