Remove the redundant compile.cmd script #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Appveyor Windows builds, include the verbose option when installing pyodbc so that all compilation warnings and errors can be seen.
It used to be necessary to have special DOS compilation commands when compiling earlier versions of pyodbc but that is no longer needed. Besides, we build Windows wheels in Github Actions now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Windows wheels in Appveyor on earlier Python versions (e.g. <=3.4), it was necessary to use special DOS commands. This was handled by the compile.cmd script. This is no longer the case, and besides, we typically build Windows wheels in Github Actions now (Appveyor is still used for Windows tests though because of the need to install a bunch of ODBC drivers).
Also, quick tweak to add the verbose option when compiling pyodbc.