Conversation
Owner
mkutz
commented
Nov 19, 2025
mkutz
commented
- Add basic pixel-wise comparisson
- Make reviewing work with images
- Add isMoreDifferentThan to reduce effort
mkutz
force-pushed
the
152-add-support-for-images
branch
from
60ca96e to
c9c20e8
Compare
mkutz
force-pushed
the
152-add-support-for-images
branch
2 times, most recently
from
91746db to
8a1e72e
Compare
mkutz
force-pushed
the
152-add-support-for-images
branch
from
8a1e72e to
fb2088a
Compare
Replace flaky pixel-by-pixel comparison with perceptual hashing (pHash) as the default image comparison strategy. pHash is robust to antialiasing, font rendering variations, and minor visual differences. New features: - ImageComparator interface with pluggable comparison strategies - PerceptualHashComparator using DCT algorithm (default, 90% threshold) - PixelComparator for exact-match use cases (1% threshold) - approveImage(byte[]) overload for direct use with Playwright/Selenium - byFile() convenience method matching text approval API - Configurable thresholds via withThreshold() fluent method Documentation: - New Images chapter covering comparators, thresholds, and best practices - Examples for both Playwright and Selenium - Tips for handling animations, dynamic content, and rendering differences
The CSS selector ".version" does not match any element on approvej.org. The version is rendered by Asciidoctor as <span id="revnumber">, so use "#revnumber" instead.
Add ImageScrubbers factory with region() and regions() methods to mask rectangular areas in screenshots before comparison. Integrate via ImageApprovalBuilder.scrubbedOf(). Clean up received files on successful approval in ImageFileApprover.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.