Allow users to send access request messages via Discord #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally I'd still like to wait for the logo asset before merge, but it's not a blocker and that can easily be its own commit anyway. |
riptl
reviewed
Aug 2, 2023
riptl
reviewed
Aug 6, 2023
| Username string `json:"username"` | ||
| ID uint64 `json:"id"` | ||
| Username string `json:"username"` | ||
| AvatarHash string `json:"avatar"` |
There was a problem hiding this comment.
Looks fine for now. I suggest putting user information in the SQLite database long term, so the JWT doesn't grow without bounds.
riptl
reviewed
Aug 6, 2023
| return | ||
| } | ||
|
|
||
| // TODO query ACL to ensure user account exists |
There was a problem hiding this comment.
I don't understand this TODO comment ... If the username doesn't exist in the UserManager, we can just add them before authorizing.
riptl
approved these changes
Aug 6, 2023
|
Thank you for the contribution @vabold 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.