Make Js.Math.min/max

ml-in-barcelona · Aug 28, 2024 · f138d12 · f138d12
1 parent fa5e286
commit f138d12
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/packages/melange.js/Js.ml b/packages/melange.js/Js.ml
@@ -1543,13 +1543,13 @@ end = struct
   let log1p _ = notImplemented "Js.Math" "log1p"
   let log10 _ = notImplemented "Js.Math" "log10"
   let log2 _ = notImplemented "Js.Math" "log2"
-  let max_int _ = notImplemented "Js.Math" "max_int"
+  let max_int (a : int) (b : int) = Stdlib.max a b
   let maxMany_int _ = notImplemented "Js.Math" "maxMany_int"
-  let max_float _ = notImplemented "Js.Math" "max_float"
+  let max_float (a : float) (b : float) = Stdlib.max a b
   let maxMany_float _ = notImplemented "Js.Math" "maxMany_float"
-  let min_int _ = notImplemented "Js.Math" "min_int"
+  let min_int (a : int) (b : int) = Stdlib.min a b
   let minMany_int _ = notImplemented "Js.Math" "minMany_int"
-  let min_float _ = notImplemented "Js.Math" "min_float"
+  let min_float (a : float) (b : float) = Stdlib.min a b
   let minMany_float _ = notImplemented "Js.Math" "minMany_float"
   let pow_float ~base:_ ~exp:_ = notImplemented "Js.Math" "pow_float"
   let random _ = notImplemented "Js.Math" "random"

diff --git a/packages/melange.js/Js.mli b/packages/melange.js/Js.mli
@@ -1164,32 +1164,24 @@ module Math : sig
     not_implemented "is not implemented in native under server-reason-react.js"]
 
   val max_int : int -> int -> int
-  [@@alert
-    not_implemented "is not implemented in native under server-reason-react.js"]
 
   val maxMany_int : int array -> int
   [@@alert
     not_implemented "is not implemented in native under server-reason-react.js"]
 
   val max_float : float -> float -> float
-  [@@alert
-    not_implemented "is not implemented in native under server-reason-react.js"]
 
   val maxMany_float : float array -> float
   [@@alert
     not_implemented "is not implemented in native under server-reason-react.js"]
 
   val min_int : int -> int -> int
-  [@@alert
-    not_implemented "is not implemented in native under server-reason-react.js"]
 
   val minMany_int : int array -> int
   [@@alert
     not_implemented "is not implemented in native under server-reason-react.js"]
 
   val min_float : float -> float -> float
-  [@@alert
-    not_implemented "is not implemented in native under server-reason-react.js"]
 
   val minMany_float : float array -> float
   [@@alert