-
Notifications
You must be signed in to change notification settings - Fork 60
Fix image rendering: add missing alt tags #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @dawidl022, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical documentation rendering issue where images in the online book and its generated PDF were displayed incorrectly due to missing alternative text. By systematically adding descriptive Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is a great contribution that improves the accessibility and rendering of the book by adding the missing alt attributes to images. The alt texts are generally accurate and descriptive. I've made a couple of minor suggestions to make them even better and more consistent. I also noticed you've fixed a line wrapping issue, which is a nice touch. Thank you for this fix!
6e13fcb to
575ca90
Compare
|
@gemini-code-assist comments addressed |
|
Thanks for addressing the comments, @dawidl022! The changes look good and significantly improve the documentation's accessibility and correctness. Great work! |
575ca90 to
1256a70
Compare
The book at https://book.mlc.ai and the generated PDF were rendering the wrong images in places due to missing alt text, which is used by d2lbook for the figure captions.
This change adds alt text to all images which did not have it before, thus fixing the rendering issue.
I have made this change before reading the book, as such if there are some captions that I got wrong, I would appreciate corrections!