Skip to content

Conversation

@dawidl022
Copy link
Contributor

@dawidl022 dawidl022 commented Jan 11, 2026

The book at https://book.mlc.ai and the generated PDF were rendering the wrong images in places due to missing alt text, which is used by d2lbook for the figure captions.

This change adds alt text to all images which did not have it before, thus fixing the rendering issue.

I have made this change before reading the book, as such if there are some captions that I got wrong, I would appreciate corrections!

@gemini-code-assist
Copy link

Summary of Changes

Hello @dawidl022, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical documentation rendering issue where images in the online book and its generated PDF were displayed incorrectly due to missing alternative text. By systematically adding descriptive alt attributes to all affected images, the change ensures that the d2lbook system can correctly generate figure captions, thereby improving the overall accuracy and accessibility of the educational material.

Highlights

  • Image Rendering Fix: Adds missing alt tags to image markdown syntax across several .md files to resolve rendering issues in the book and generated PDF. Previously, the absence of alt text, which d2lbook uses for figure captions, led to incorrect images being displayed.
  • Documentation Clarity: Enhances the clarity and accessibility of the documentation by providing descriptive alternative text for all images, ensuring that the content is understandable even when images cannot be rendered or for users relying on screen readers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a great contribution that improves the accessibility and rendering of the book by adding the missing alt attributes to images. The alt texts are generally accurate and descriptive. I've made a couple of minor suggestions to make them even better and more consistent. I also noticed you've fixed a line wrapping issue, which is a nice touch. Thank you for this fix!

@dawidl022 dawidl022 force-pushed the fix/image-alt-tags branch 2 times, most recently from 6e13fcb to 575ca90 Compare January 11, 2026 20:37
@dawidl022
Copy link
Contributor Author

@gemini-code-assist comments addressed

@gemini-code-assist
Copy link

Thanks for addressing the comments, @dawidl022! The changes look good and significantly improve the documentation's accessibility and correctness. Great work!

@tqchen tqchen merged commit 4d9a9b4 into mlc-ai:main Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants