Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Pandas 2.0 #627

Closed
hasan7n opened this issue Apr 25, 2023 · 9 comments · Fixed by #628 or #740
Closed

Port to Pandas 2.0 #627

hasan7n opened this issue Apr 25, 2023 · 9 comments · Fixed by #628 or #740
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@hasan7n
Copy link
Contributor

hasan7n commented Apr 25, 2023

Describe the bug
when running gandlf_run, I am encountering:

ERROR: 'DataFrame' object has no attribute 'append'

To Reproduce

Train a model using gandlf_run.

I trained using 2d_rad_segmentation data from https://upenn.box.com/shared/static/y8162xkq1zz5555ye3pwadry2m2e39bs.zip and the config file from samples in the repo config_classification.yaml

Additional context

  • check the changelog of pandas here
  • The training runs successfully when downgrading pandas to 1.5.3
@sarthakpati sarthakpati linked a pull request Apr 25, 2023 that will close this issue
11 tasks
@sarthakpati sarthakpati self-assigned this Apr 25, 2023
@sarthakpati
Copy link
Collaborator

Unless we have a specific requirement for pandas>=2.0, my recommendation would be to stick with pandas<2.0. This will ensure long-term stability of the next release. We can update this requirement along with PyTorch (#587) in the future.

@sarthakpati sarthakpati changed the title pandas >=2.0.0 incompatibility? Add compatibility for Pandas >= 2.0 May 8, 2023
@sarthakpati
Copy link
Collaborator

Reopening and assigning this for code-reorg.

@sarthakpati sarthakpati reopened this May 8, 2023
@sarthakpati sarthakpati changed the title Add compatibility for Pandas >= 2.0 Port to Pandas 2.0 May 8, 2023
@sarthakpati sarthakpati added the dependencies Pull requests that update a dependency file label May 20, 2023
@github-actions
Copy link
Contributor

Stale issue message

@github-actions
Copy link
Contributor

Stale issue message

@Ainesh06102004
Copy link
Contributor

I'll gladly take this on.

@sarthakpati
Copy link
Collaborator

Thanks @Ainesh06102004, this is now assigned to you!

@Ainesh06102004
Copy link
Contributor

When upgrading pandas to 2.0.0 version, it is becoming incompatibe with numpy 1.22.0 version, which is currently being used.

@sarthakpati
Copy link
Collaborator

When upgrading pandas to 2.0.0 version, it is becoming incompatibe with numpy 1.22.0 version, which is currently being used.

@szmazurek you are working on the numpy version port, right?

@szmazurek
Copy link
Collaborator

Yes, if nothing goes wrong the PR goes tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants