Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade base pandas version #740

Merged
merged 24 commits into from
Nov 21, 2023
Merged

Upgrade base pandas version #740

merged 24 commits into from
Nov 21, 2023

Conversation

Ainesh06102004
Copy link
Contributor

Fixes #627

Proposed Changes

  • upgraded pandas related code to its 2.0.0 version

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@Ainesh06102004
changed code for pandas to pandas>=2.0.0
01daf06
@Ainesh06102004
made change
62a4714
@Ainesh06102004
Merge branch 'master' of https://github.com/mlcommons/GaNDLF into por…
e9969b6 
…t_to_pandas_2.0
@Ainesh06102004
changed code from dataframe.append to dataframe._append
ddc3d36
@Ainesh06102004
works fine
9b8aea1
@Ainesh06102004
test cases 12,13 and 14 failed with weird errors
5e3396d
@Ainesh06102004
few errors, have commented them, proceeding with rest for now
b58d580
@Ainesh06102004
Merge branch 'master' of https://github.com/mlcommons/GaNDLF into por…
13000c0 
…t_to_pandas_2.0
@Ainesh06102004
numpy error raised
5ac161e
@Ainesh06102004
Merge branch 'feature/python_3_10_numpy_1_25' of https://github.com/s…
2e7abaa 
…zmazurek/GaNDLF into port_to_pandas_2.0
@Ainesh06102004
some fuctions have given contextual version error with pandas
fb2a2fe
@Ainesh06102004
some functions are giving contextual version error and some are givin…
4d9b8f1 
…g no pandas errors like attribute error and value errors
@Ainesh06102004
Merge branch 'master' of https://github.com/mlcommons/GaNDLF into por…
8f00140 
…t_to_pandas_2.0
@Ainesh06102004
upgraded all code related to pandas to its 2.0.0 version
9a13a24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@Ainesh06102004 Ainesh06102004 marked this pull request as ready for review November 17, 2023 07:40
@sarthakpati sarthakpati changed the title Port to pandas 2.0 Upgrade base pandas version Nov 17, 2023
@sarthakpati sarthakpati self-requested a review November 17, 2023 20:53
@Ainesh06102004 Ainesh06102004 marked this pull request as draft November 20, 2023 16:03
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87af776) 94.71% compared to head (6c5d5c6) 94.69%.
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   94.71%   94.69%   -0.02%     
==========================================
  Files         117      117              
  Lines        8224     8222       -2     
==========================================
- Hits         7789     7786       -3     
- Misses        435      436       +1
Flag Coverage Δ
unittests 94.69% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ainesh06102004 Ainesh06102004 marked this pull request as ready for review November 21, 2023 13:41
sarthakpati
sarthakpati approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Code coverage reduced because the number of lines of code increased.

@sarthakpati sarthakpati merged commit 99b9abd into mlcommons:master Nov 21, 2023
16 of 17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port to Pandas 2.0
2 participants
@Ainesh06102004 @sarthakpati