Skip to content

Incorporate modellogger #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
superdosh merged 7 commits into from
Jan 14, 2026
Merged

Incorporate modellogger #1448

superdosh merged 7 commits into from
Jan 14, 2026

Conversation

@superdosh
Copy link
Contributor

@superdosh superdosh commented Jan 13, 2026 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Jan 13, 2026 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@superdosh superdosh temporarily deployed to Scheduled Testing January 13, 2026 15:33 — with GitHub Actions Inactive
@superdosh superdosh marked this pull request as ready for review January 13, 2026 15:35
@superdosh superdosh requested a review from a team as a code owner January 13, 2026 15:35
superdosh
superdosh commented Jan 13, 2026
View reviewed changes
tests/modelgauge_tests/conftest.py
Copy link
Contributor Author

@superdosh superdosh Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpietri did you have to do something like this in cheval too? I wonder if maybe it's better handled in modellogger (e.g. we clear all but the caplog handler, if present?).

Copy link
Contributor

@bkorycki bkorycki Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think it makes more sense to handle it in modellogger (if possible) so that we don't have to repeat this code in our various projects.

Copy link
Contributor Author

@superdosh superdosh Jan 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a stab at it here: mlcommons/modellogger#4

bkorycki
bkorycki approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@bkorycki bkorycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/modelgauge_tests/conftest.py
Copy link
Contributor

@bkorycki bkorycki Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think it makes more sense to handle it in modellogger (if possible) so that we don't have to repeat this code in our various projects.

@superdosh
Copy link
Contributor Author

superdosh commented Jan 13, 2026

Requires: mlcommons/modellogger#4

@superdosh superdosh temporarily deployed to Scheduled Testing January 13, 2026 18:42 — with GitHub Actions Inactive
@superdosh superdosh temporarily deployed to Scheduled Testing January 14, 2026 02:13 — with GitHub Actions Inactive
@superdosh superdosh merged commit 91d8075 into main Jan 14, 2026
2 checks passed
@superdosh superdosh deleted the better-logging branch January 14, 2026 02:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wpietri wpietri wpietri approved these changes

@bkorycki bkorycki bkorycki approved these changes

@dhosterman dhosterman Awaiting requested review from dhosterman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@superdosh @wpietri @bkorycki