Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal validation. #125

Merged
merged 15 commits into from
Jan 28, 2025
Merged

Fix internal validation. #125

merged 15 commits into from
Jan 28, 2025

Conversation

dsuhinin
Copy link
Collaborator

@dsuhinin dsuhinin commented Jan 27, 2025 •
edited
Loading

blocked by -> mlflow/mlflow#14353

dsuhinin and others added 13 commits December 11, 2024 16:32
@dsuhinin
move PATCH /mlflow/model-versions/update endpoint.
6b5c7a3 
Signed-off-by: Software Developer <suhinin.dmitriy@gmail.com>
Revert "move PATCH /mlflow/model-versions/update endpoint."
57f1d40 
This reverts commit 6b5c7a3.
@dsuhinin
Merge branch 'mlflow:main' into main
fa0c286
@dsuhinin
Merge branch 'mlflow:main' into main
c203251
@dsuhinin
Merge branch 'mlflow:main' into main
bfc1de9
@dsuhinin
Merge branch 'mlflow:main' into main
1ef01ae
@dsuhinin
Merge branch 'mlflow:main' into main
5f22278
@dsuhinin
Merge branch 'mlflow:main' into main
263bd46
@dsuhinin
Merge branch 'mlflow:main' into main
1ba3f17
@dsuhinin
Merge branch 'mlflow:main' into main
1a85f92
@dsuhinin
Merge branch 'mlflow:main' into main
73b1a56
@dsuhinin
*validation hot fix.
ab62591 
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
@dsuhinin
add new notEmpty validator.
81bcf07 
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
nojaf
nojaf reviewed Jan 27, 2025
View reviewed changes
pkg/validation/validation.go Outdated Show resolved Hide resolved
@dsuhinin
*more validation fixes.
594313f 
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
@dsuhinin dsuhinin mentioned this pull request Jan 27, 2025
Merged
@nojaf
Copy link
Collaborator

nojaf commented Jan 27, 2025

@dsuhinin could you change your .mlflow.ref to dsuhinin:fix_validation_for_rename_registered_model to see if CI agrees with it?

@dsuhinin
*PR remarks.
c0bc7c8 
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
@dsuhinin
Copy link
Collaborator Author

@dsuhinin could you change your .mlflow.ref to dsuhinin:fix_validation_for_rename_registered_model to see if CI agrees with it?

emmm, but I already did it and so far so good, it looks green.

@dsuhinin dsuhinin requested a review from nojaf January 27, 2025 20:34
@dsuhinin dsuhinin enabled auto-merge (squash) January 27, 2025 20:46
nojaf
nojaf approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsuhinin dsuhinin merged commit 6c66078 into mlflow:main Jan 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsuhinin @nojaf