Improve logging (DBAI-37) #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssciolla
commented
Apr 23, 2024
| begin | ||
| track!(status: BagStatus::BAGGING) | ||
| bag_path = File.join(@working_dir, @bag_id.to_s) | ||
| bag = BagAdapter::BagAdapter.new(bag_path) | ||
|
|
||
| track!(status: BagStatus::COPYING) | ||
| logger.measure_info("Copied data for bag #{@bag_id} in #{@working_dir}.") do |
There was a problem hiding this comment.
@bag_id is repeated for most messages I added here because there might be a future in which we add concurrency at the level of bag_courier.deliver calls. In that case, having the ID would be important for connecting log messages.
jayamala17
reviewed
Apr 23, 2024
jayamala17
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve DBAI-37. It adds
INFOlevel log messages and timed messages to better indicate/analyze progress and performance during runs.