Add setting to only process a limited number of objects per run (DBAI-51) #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssciolla
added
enhancement
ssciolla
commented
Apr 26, 2024
| filtered_packages.map { |package| create_package_data_object(package) } | ||
| filtered_packages | ||
| .map { |package| create_package_data_object(package) } | ||
| .sort_by(&:stored_time) |
There was a problem hiding this comment.
As noted in the modified tests, my testing indicated that the order returned is ascending order by stored_date, but I've added this as a precaution. Batching would be severely broken (i.e. we'd miss packages) if the ordering changed, and the sort here seems like a low computation cost for at most hundreds of hashes/objects.
jayamala17
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve DBAI-51.