Update hidden files flag #56
Conversation
jayamala17
commented
Aug 5, 2024
•
jayamala17
commented
- To Support hidden file scenario while validating it using BagIt, detect hidden flag is added
- Changes are made to validate hidden files by enabling detect hidden flag.
- Updated rexml version to 3.3.4 to handle security vulnerability (https://github.com/mlibrary/bag-courier/security/dependabot)
lib/bag_adapter.rb
Outdated
| ValidationResult.new(is_valid: is_valid, error_message: nil) | ||
| else | ||
| ValidationResult.new( | ||
| is_valid: is_valid, | ||
| error_message: @bag.errors.full_messages.join(", ") | ||
| ) |
There was a problem hiding this comment.
Should this be this instead? Not sure.
| ValidationResult.new(is_valid: is_valid, error_message: nil) | |
| else | |
| ValidationResult.new( | |
| is_valid: is_valid, | |
| error_message: @bag.errors.full_messages.join(", ") | |
| ) | |
| ValidationResult.new( | |
| is_valid: is_valid, | |
| error_message: is_valid ? nil : @bag.errors.full_messages.join(", ") | |
| ) |
There was a problem hiding this comment.
is_valid would be false always so wont be nil. I feel we dont need this check.
There was a problem hiding this comment.
Well, I was wondering whether we could just use the conditional with error_message. My suggestion might be messed up, hold on.
There was a problem hiding this comment.
Like this, remove the outer conditional, just use a ternary with message. https://github.com/mlibrary/bag-courier/pull/56/files#r1705968354
There was a problem hiding this comment.
We can leave it the way it is, just wondering what you thought.
There was a problem hiding this comment.
sorry i got confused with unified lines. Now i got it. I think it will more readable and concise to have it this way which will handle both the condition.
Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
…patcher, BagCourier, and uses
