Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

July 2023 dependency updates. #32

Merged
merged 3 commits into from
Jul 13, 2023
Merged

July 2023 dependency updates. #32

merged 3 commits into from
Jul 13, 2023

Conversation

erinesullivan
Copy link
Collaborator

@erinesullivan erinesullivan commented Jul 5, 2023

Overview

Monthly dependency update to help maintain Get This. Files with updates:

  • package-lock.json
  • Gemfile.lock
  • Dockerfile

For Dockerfile, the install of apt-transport-https was moved down to where all of the apt-installs happen since there's no reason it needs to be before fetching node.

Testing

  • Install the updated packages (docker-compose run --rm web npm install).
  • Make a CSS change, and build the styles (docker-compose run --rm web npm run build).
  • Start the site to see if your change was made, and everything still works (docker-compose up).
  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge

@erinesullivan erinesullivan added the dependencies Changes to packages or gems. label Jul 5, 2023
@erinesullivan erinesullivan self-assigned this Jul 5, 2023
Copy link
Collaborator

@niquerio niquerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it in the workshop. It looks fine. 🚢

@niquerio niquerio merged commit 0ce1006 into main Jul 13, 2023
1 check passed
@erinesullivan erinesullivan deleted the 2023-07-05-updates branch February 13, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to packages or gems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants