Ensure that SSL support is enabled in HttpClient #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http-check tool was working fine with HTTPS because it enabled the support before it included httplib.h. However, the HttpClient implementation did not, which mean that the whole of the shared library was not supporting HTTPS. When using the API over HTTPS, this was silently crashing the module because of an uncaught exception. This would normally produce stdout or stderr output, but it is squelched by the Apache process management. We add an additional api-check binary that enables a cursory check of using the Authorizer against an HTTP or HTTPS API instance from the command line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http-check tool was working fine with HTTPS because it enabled the support before it included httplib.h. However, the HttpClient implementation did not, which mean that the whole of the shared library was not supporting HTTPS.
When using the API over HTTPS, this was silently crashing the module because of an uncaught exception. This would normally produce stdout or stderr output, but it is squelched by the Apache process management.
We add an additional api-check binary that enables a cursory check of using the Authorizer against an HTTP or HTTPS API instance from the command line.