-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize string cache in context #349
Conversation
Looks good to me! I'm just wondering if you can just use |
I'm not sure if you are asking if it's possible to add a For the former, we can but then we cannot use the For the latter, we cannot in general because we use
I'm thinking of introducing dynamic checks for #271 instead. I think we need those checks anyway to check, for example, if given attributes are from the same context as existing attributes in an operation. |
I meant the latter, but I didn't realize using |
looks good to me! |
Thank you everyone for reviews! |
This PR removes the global static string cache that stores
CString
in MLIR (C++) for each corresponding&str
in Rust. Instead, we have a cache in each context. And, that forces users to pass around the newContext
type accordingly.Close #54.
This change is also the base of #271, #23, and #348.