Refactor dialect macro input

macro/Cargo.toml

@@ -19,7 +19,7 @@ proc-macro2 = "1"
 quote = "1"
 regex = "1.11.1"
 syn = { version = "2", features = ["full"] }
-tblgen = { version = "0.4.0", features = [
+tblgen = { git = "https://github.com/raviqqe/tblgen-rs-alt", branch = "feature/include-file", features = [
   "llvm19-0",
 ], default-features = false, package = "tblgen-alt" }
 unindent = "0.2.3"

macro/src/dialect.rs

@@ -16,41 +16,50 @@ use operation::Operation;
 use proc_macro::TokenStream;
 use proc_macro2::Span;
 use quote::quote;
-use std::{env, fmt::Display, path::Path, str};
+use std::{
+    env,
+    fmt::Display,
+    path::{Component, Path},
+    str,
+};
 use tblgen::{record::Record, record_keeper::RecordKeeper, TableGenParser};
 
+const LLVM_INCLUDE_DIRECTORY: &str = env!("LLVM_INCLUDE_DIRECTORY");
+
 pub fn generate_dialect(input: DialectInput) -> Result<TokenStream, Box<dyn std::error::Error>> {
     let mut parser = TableGenParser::new();
 
     if let Some(source) = input.table_gen() {
-        let base = Path::new(env!("LLVM_INCLUDE_DIRECTORY"));
-
-        // Here source looks like `include "foo.td" include "bar.td"`.
-        for (index, path) in source.split_ascii_whitespace().enumerate() {
-            if index % 2 == 0 {
-                continue; // skip "include"
-            }
-
-            let path = &path[1..(path.len() - 1)]; // remove ""
-            let path = Path::new(path).parent().unwrap();
-            let path = base.join(path);
-            parser = parser.add_include_path(&path.to_string_lossy());
-        }
-
         parser = parser.add_source(source).map_err(create_syn_error)?;
     }
 
     if let Some(file) = input.td_file() {
         parser = parser.add_source_file(file).map_err(create_syn_error)?;
     }
 
-    for path in input
-        .include_directories()
-        .chain([env!("LLVM_INCLUDE_DIRECTORY")])
-    {
+    for path in input.include_directories().chain([LLVM_INCLUDE_DIRECTORY]) {
         parser = parser.add_include_path(path);
     }
 
+    let llvm_include_directory = Path::new(LLVM_INCLUDE_DIRECTORY);
+
+    for path in input.directories() {
+        let path = if matches!(
+            Path::new(path).components().next(),
+            Some(Component::CurDir | Component::ParentDir)
+        ) {
+            path.into()
+        } else {
+            llvm_include_directory.join(path).display().to_string()
+        };
+
+        parser = parser.add_include_path(&path);
+    }
+
+    for path in input.files() {
+        parser = parser.add_source_file(path).map_err(create_syn_error)?;
+    }
+
     let keeper = parser.parse().map_err(Error::Parse)?;
 
     let dialect = generate_dialect_module(

macro/src/dialect/input.rs

@@ -6,9 +6,14 @@ use syn::{parse::Parse, punctuated::Punctuated, Token};
 
 pub struct DialectInput {
     name: String,
+    // TODO Remove this field.
     table_gen: Option<String>,
+    // TODO Remove this field.
     td_file: Option<String>,
+    // TODO Remove this field.
     include_directories: Vec<String>,
+    files: Vec<String>,
+    directories: Vec<String>,
 }
 
 impl DialectInput {
@@ -27,6 +32,14 @@ impl DialectInput {
     pub fn include_directories(&self) -> impl Iterator<Item = &str> {
         self.include_directories.iter().map(Deref::deref)
     }
+
+    pub fn files(&self) -> impl Iterator<Item = &str> {
+        self.files.iter().map(Deref::deref)
+    }
+
+    pub fn directories(&self) -> impl Iterator<Item = &str> {
+        self.directories.iter().map(Deref::deref)
+    }
 }
 
 impl Parse for DialectInput {
@@ -35,6 +48,8 @@ impl Parse for DialectInput {
         let mut table_gen = None;
         let mut td_file = None;
         let mut includes = vec![];
+        let mut files = vec![];
+        let mut directories = vec![];
 
         for item in Punctuated::<InputField, Token![,]>::parse_terminated(input)? {
             match item {
@@ -44,6 +59,12 @@ impl Parse for DialectInput {
                 InputField::IncludeDirectories(field) => {
                     includes = field.into_iter().map(|literal| literal.value()).collect()
                 }
+                InputField::Files(field) => {
+                    files = field.into_iter().map(|literal| literal.value()).collect()
+                }
+                InputField::Directories(field) => {
+                    directories = field.into_iter().map(|literal| literal.value()).collect()
+                }
             }
         }
 
@@ -52,6 +73,8 @@ impl Parse for DialectInput {
             table_gen,
             td_file,
             include_directories: includes,
+            files,
+            directories,
         })
     }
 }

macro/src/dialect/input/input_field.rs

@@ -7,6 +7,8 @@ pub enum InputField {
     TableGen(LitStr),
     TdFile(LitStr),
     IncludeDirectories(Punctuated<LitStr, Token![,]>),
+    Files(Punctuated<LitStr, Token![,]>),
+    Directories(Punctuated<LitStr, Token![,]>),
 }
 
 impl Parse for InputField {
@@ -27,6 +29,18 @@ impl Parse for InputField {
             Ok(Self::IncludeDirectories(
                 Punctuated::<LitStr, Token![,]>::parse_terminated(&content)?,
             ))
+        } else if ident == format_ident!("files") {
+            let content;
+            bracketed!(content in input);
+            Ok(Self::Files(
+                Punctuated::<LitStr, Token![,]>::parse_terminated(&content)?,
+            ))
+        } else if ident == format_ident!("include_directories") {
+            let content;
+            bracketed!(content in input);
+            Ok(Self::Directories(
+                Punctuated::<LitStr, Token![,]>::parse_terminated(&content)?,
+            ))
         } else {
             Err(input.error(format!("invalid field {}", ident)))
         }

melior/src/dialect/ods.rs

@@ -32,9 +32,8 @@ melior_macro::dialect! {
 }
 melior_macro::dialect! {
     name: "arm_sme",
-    table_gen: r#"include "mlir/Dialect/ArmSME/IR/ArmSME.td"
-        include "mlir/Dialect/ArmSME/IR/ArmSMEOps.td"
-        include "mlir/Dialect/ArmSME/IR/ArmSMEIntrinsicOps.td""#
+    files: ["ArmSME.td", "ArmSMEOps.td", "ArmSMEIntrinsicOps.td"],
+    include_directories: ["mlir/Dialect/ArmSME/IR"],
 }
 melior_macro::dialect! {
     name: "async",
@@ -86,7 +85,8 @@ melior_macro::dialect! {
 }
 melior_macro::dialect! {
     name: "irdl",
-    table_gen: r#"include "mlir/Dialect/IRDL/IR/IRDL.td" include "mlir/Dialect/IRDL/IR/IRDLOps.td""#
+    files: ["IRDL.td", "IRDLOps.td"],
+    include_directories: ["mlir/Dialect/IRDL/IR"],
 }
 melior_macro::dialect! {
     name: "llvm",