Refactor dialect macro input #655
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I published a new version of tblgen v0.5.0 |
This reverts commit 53668df.
raviqqe
commented
Jan 8, 2025
macro/src/dialect.rs
Outdated
| parser = parser.add_source( | ||
| &input | ||
| .files() | ||
| .map(|path| format!(r#"include "{path}""#)) |
There was a problem hiding this comment.
I noticed that the llvm::SourceMgr class doens't actually handle "multiple files" but there is only one main file and other complementary files in there. So we didn't have to fix the TableGenParser::add_source_file. method...
For now, we fall back to the original approach of defining the main file on the fly with a bunch of include statements.
There was a problem hiding this comment.
Actually, now I wonder if we should expose the add_source and add_source_file methods of TableGenParser in the current way because it's confusing and only the first call of the method makes sense in most cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors dialect macro input.
References
AddIncludeFilemethod tblgen-rs-alt#18