Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nvme store for venv on aws-gpu with pip #126

Conversation

leifdenby
Copy link
Member

@leifdenby leifdenby commented Feb 12, 2025

Describe your changes

Testing are failing on AWS (gpu) testing with pip in #118 due to running out of disk space, because I didn't set it up so that the nvme drive is used to store the virtual environment when testing install with pip (I only did this when testing the install with pdm, I should have done it for both at the time).

This PR also adds a comment to explain recent change of the cirun configuration (that was accidentally included with #123, specifically 103c8b7#diff-e81f821c9d78ca5d2124cc284d225882a2644cb071b20016e922643efbe00812R9) that was done to enlarge the root volume to 200GB to circumvent running out of disk space.

No change in dependencies.

Issue Link

#118

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)
  • maintenance

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@leifdenby leifdenby marked this pull request as ready for review February 13, 2025 12:18
@leifdenby leifdenby requested a review from SimonKamuk February 14, 2025 08:37
@leifdenby leifdenby added the cicd label Feb 14, 2025
@leifdenby leifdenby mentioned this pull request Feb 17, 2025
20 tasks
@leifdenby leifdenby merged commit 43524f7 into mllam:main Feb 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants