Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated cicd badges with new test matrix #130

Merged
merged 5 commits into from
Feb 17, 2025

Conversation

SimonKamuk
Copy link
Contributor

@SimonKamuk SimonKamuk commented Feb 17, 2025

Describe your changes

This PR updates the cicd badges in the readme to use the new test matrix, which was recently added instead of the individual ci runs for gpu/cpu pdm/pip.

Also fixes the link in the linting badge.

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • I have updated the README to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)
  • Once the PR is ready to be merged, squash commits and merge the PR.

@SimonKamuk SimonKamuk added the bug Something isn't working label Feb 17, 2025
@SimonKamuk SimonKamuk requested a review from leifdenby February 17, 2025 10:15
@SimonKamuk SimonKamuk self-assigned this Feb 17, 2025
Copy link
Member

@leifdenby leifdenby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, I overlooked this when I changed so we only have one file :/

Could you maybe rename the action from "Test Matrix" too, to say "CPU+GPU testing" or something better? "Test Matrix" doesn't quite cover it. I should've done this in my PR too

@SimonKamuk
Copy link
Contributor Author

Thanks for fixing this, I overlooked this when I changed so we only have one file :/

Could you maybe rename the action from "Test Matrix" too, to say "CPU+GPU testing" or something better? "Test Matrix" doesn't quite cover it. I should've done this in my PR too

Done 😄

@leifdenby
Copy link
Member

sorry, I should have made that clearer. You'll need to change the name of the action here: https://github.com/mllam/neural-lam/blob/main/.github/workflows/install-and-test.yml#L21

@SimonKamuk
Copy link
Contributor Author

Right, fixed that now 👌

@SimonKamuk SimonKamuk merged commit ada9c16 into mllam:main Feb 17, 2025
8 checks passed
@SimonKamuk SimonKamuk deleted the fix/cicd_badges branch February 18, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants