Allow custom paths in Discord avatars #107
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 71.90% 71.90% -0.01%
==========================================
Files 60 60
Lines 2442 2445 +3
Branches 514 516 +2
==========================================
+ Hits 1756 1758 +2
- Misses 626 627 +1
Partials 60 60 ☔ View full report in Codecov by Sentry. |
This will load avatars from local directories if exports have media files enabled. Fixes #106
mlomb
force-pushed
the
discord-local-avatars
branch
from
a4c2f43 to
fba64b2
Compare
|
⚡ Preview for this PR: https://pr-107.chat-analytics.pages.dev |
|
Line 38 in 61a8f06
This should maybe be updated. Of course, the link could still "expire" if the user deletes the media, but I think there should be some sort of mention of the difference between how media is handled when media is/isn't used |
| // assume it's a custom avatar stored as media | ||
| // store the full path to the avatar | ||
| // note that this will not work unless the user puts the report.html in the correct | ||
| // folder, but since we don't have the online URL, we do this as best-effort |
There was a problem hiding this comment.
The user should probably be informed of this in some way, perhaps in the header of the report similarly to the header used for the demo. Also, once configuration is added, the user should have the option to embed images in the report (both with and without media, since Discord profile picture links expire)
There was a problem hiding this comment.
I think it should be a warning after the generation process. Showing a header like the demo that can't be easily removed will be annoying.
Embedding images is also complicated. With links it's not possible, since we may have to download thousands of images off Discord servers at once, which is bad. With local files, it may be possible but there isn't an easy way right now and I don't think it's worth it.
This will load avatars from local directories if exports have media files enabled. Fixes #106