chore: add repo best practices (templates, linter config, editor config)#13
Merged
mlorentedev merged 3 commits intomasterfrom Mar 8, 2026
Merged
chore: add repo best practices (templates, linter config, editor config)#13mlorentedev merged 3 commits intomasterfrom
mlorentedev merged 3 commits intomasterfrom
Conversation
- Add PR template and YAML issue forms (bug report, feature request) - Add SECURITY.md with vulnerability reporting process - Add CLAUDE.md with project-level instructions for Claude Code - Add .golangci.yml to pin linter configuration - Add .editorconfig for cross-editor consistency - Fix stale Go version in CONTRIBUTING.md (1.21+ → 1.25+) - Unignore CLAUDE.md from .gitignore (project instructions should be tracked)
- Replace hardcoded "127.0.0.1:33389" with defaultLocalAddr constant in tests - Exclude test files from gocyclo (table-driven tests are legitimately complex) - Suppress unparam for acceptLoop (returns nil by design on clean shutdown)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.golangci.ymlto pin linter configuration (15 linters enabled).editorconfigfor cross-editor consistencyCLAUDE.mdwith tech stack, key paths, and conventionsChanges
.github/pull_request_template.md: PR checklist template.github/ISSUE_TEMPLATE/bug_report.yml: Structured bug report form.github/ISSUE_TEMPLATE/feature_request.yml: Feature request form.github/ISSUE_TEMPLATE/config.yml: Disable blank issues, link to docsSECURITY.md: Vulnerability reporting processCLAUDE.md: Project instructions for Claude Code.golangci.yml: Pinned linter config (gocyclo, gosec, misspell, etc.).editorconfig: Tabs for Go, spaces for YAML/MD, CRLF for PS1CONTRIBUTING.md: Go 1.21+ → 1.25+.gitignore: Unignore CLAUDE.mdTesting
go test -race ./...passes (no code changes)go vet ./...cleango build ./...cleanType
chore— MaintenanceBP-002 through BP-006 from the Best Practices Equalization backlog.